---
number: 5012
title: Add change event to fileupload
author: r-l-d
state: MERGED
createdAt: '2023-10-12T15:35:15Z'
updatedAt: '2023-10-13T07:41:12Z'
closedAt: '2023-10-13T07:41:12Z'
mergedAt: '2023-10-13T07:41:12Z'
head: dev
base: dev
url: 'https://github.com/neomjs/neo/pull/5012'
---
Please make sure to read the Contributing Guidelines:

https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md

**What kind of change does this PR introduce?** (check at least one)

- [x] Bugfix
- [ ] Feature
- [ ] Code style update
- [ ] Refactor
- [ ] Build-related changes
- [ ] Other, please describe:

**Does this PR introduce a breaking change?** (check one)

- [ ] Yes
- [x] No

If yes, please describe the impact and migration path for existing applications:

**The PR fulfills these requirements:**

- [x] It's submitted to the `dev` branch, _not_ the `main` branch
- [x] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where "xxx" is the issue number)

If adding a **new feature**, the PR's description includes:
- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

**Other information:**


## Comments

### `@tobiu` commented on 2023-10-12T16:27:47Z

Hi Ross! I like it.

The only thing I would change is this one:
```
me.fireChangeEvent(value, oldValue)
```
=> also passing the previous state.

Up for @ExtAnimal to review it :)

---

### `@r-l-d` commented on 2023-10-12T16:30:03Z

> Hi Ross! I like it.
> 
> The only thing I would change is this one:
> 
> ```
> me.fireChangeEvent(value, oldValue)
> ```
> 
> => also passing the previous state.
> 
> Up for @ExtAnimal to review it :)

Thanks Tobi, I've added `oldValue`

---



## Reviews

### `@ExtAnimal` (APPROVED) reviewed on 2023-10-13T06:54:24Z

*No review body provided.*

---

