---
id: 10529
title: Disambiguate session sunset triggers from PR review halting
state: CLOSED
labels:
  - enhancement
  - ai
  - architecture
assignees: []
createdAt: '2026-04-30T13:58:39Z'
updatedAt: '2026-04-30T14:21:20Z'
githubUrl: 'https://github.com/neomjs/neo/issues/10529'
author: neo-gemini-pro
commentsCount: 0
parentIssue: null
subIssues: []
subIssuesCompleted: 0
subIssuesTotal: 0
blockedBy: []
blocking: []
closedAt: '2026-04-30T14:21:20Z'
---
# Disambiguate session sunset triggers from PR review halting

- **Context** — The `session-sunset-workflow.md` forbids sunsetting when an agent simply halts for a turn. However, the `pull-request-workflow.md` explicitly commands an agent to "halt and await cross-model review" after opening a PR. Agents have erroneously conflated this PR halting state with a Session Boundary, causing false-positive Sunset Protocol executions.
- **The Problem** — Opening a PR starts an async review lifecycle; it does not terminate a session. Executing the Sunset Protocol at this point causes unnecessary overhead, pollutes the context with Sandman memories prematurely, and disrupts swarm continuity if the PR requires immediate polish.
- **The Architectural Reality** — The `session-sunset-workflow.md` lacks an explicit negative trigger (Anti-Trigger) for the Review Lifecycle. The agent's autonomous loops cannot distinguish between "halting to await human input" and "halting for PR peer review" without this explicit rule.
- **The Fix** — Add an explicit "Review Lifecycle Exception (Anti-Trigger)" to `.agents/skills/session-sunset/references/session-sunset-workflow.md`. Clarify that awaiting cross-model review is NOT a Session Boundary.
- **Acceptance Criteria**
  - Update `session-sunset-workflow.md` to explicitly list PR Review halting as a non-trigger.
  - Remove any ambiguity between yielding a turn and terminating a session in the context of PRs.
- **Out of Scope** — Modifying the `pull-request` skill or `ticket-intake` skill.
- **Related** — #9948

## Timeline

- 2026-04-30T13:58:41Z @neo-gemini-pro added the `enhancement` label
- 2026-04-30T13:58:41Z @neo-gemini-pro added the `ai` label
- 2026-04-30T13:58:42Z @neo-gemini-pro added the `architecture` label
- 2026-04-30T14:00:13Z @neo-gemini-pro cross-referenced by PR #10530
- 2026-04-30T14:14:05Z @neo-gemini-pro referenced in commit `0480e3d` - "fix(sunset): restrict anti-trigger to active review loops (#10529)"
- 2026-04-30T14:21:21Z @tobiu referenced in commit `f50db54` - "feat(sunset): disambiguate session sunset triggers from PR review halting (#10529) (#10530)

* feat(sunset): disambiguate session sunset triggers from PR review halting (#10529)

* fix(sunset): restrict anti-trigger to active review loops (#10529)

---------

Co-authored-by: tobiu <tobiasuhlig78@gmail.com>"
- 2026-04-30T14:21:21Z @tobiu closed this issue
- 2026-05-01T09:27:08Z @neo-opus-ada cross-referenced by #10564
- 2026-05-01T10:33:47Z @neo-opus-ada cross-referenced by #10569
- 2026-05-01T18:44:11Z @neo-opus-ada cross-referenced by PR #10596

