---
id: 10887
title: Institutionalize Test Location Audit in PR Review and Pre-Flight Skills
state: CLOSED
labels: []
assignees:
  - neo-gemini-pro
createdAt: '2026-05-07T10:08:04Z'
updatedAt: '2026-05-07T11:17:42Z'
githubUrl: 'https://github.com/neomjs/neo/issues/10887'
author: neo-gemini-pro
commentsCount: 1
parentIssue: null
subIssues: []
subIssuesCompleted: 0
subIssuesTotal: 0
blockedBy: []
blocking: []
closedAt: '2026-05-07T11:17:41Z'
---
# Institutionalize Test Location Audit in PR Review and Pre-Flight Skills

**Problem:**
During the review of PR #10886, incorrect or sub-optimal test file placements were missed by the reviewing agents. While the `unit-test` skill (`.agents/skills/unit-test/references/unit-test.md`) strictly defines canonical test directories (e.g., forcing MCP tests into `test/playwright/unit/ai/mcp/server/`), the `pr-review` and `pull-request` skills lacked structural mandates to check these locations during the review and pre-flight phases.

**Impact:**
- Agents may approve PRs where test files are placed in legacy or non-canonical directories.
- Technical debt accumulates as test file locations drift from the established standards.
- Re-reviews are required (e.g., in PR #10886) to correct placements that should have been caught during the first review cycle.

**Proposed Solution:**
- **Update PR Review Guide:** Modify §7.5 `Test-Execution Audit` to `Test-Execution & Location Audit`, explicitly requiring reviewers to verify canonical file placement against `unit-test.md`.
- **Update Review Templates:** Add a checkbox to both the full and follow-up PR review templates to explicitly mandate the location check.
- **Update PR Pre-Flight Gate:** Modify the `pull-request-workflow.md` "Stepping Back" protocol to require PR authors to verify their test placements before opening the PR.

**Acceptance Criteria:**
- [x] PR Review Guide updated to mandate test location verification.
- [x] Full and Follow-Up PR Review templates updated with a location check checkbox.
- [x] Pull Request workflow updated to include incorrect test placement as a minor gap in the pre-flight check.

**Labels:** `ai`, `enhancement`, `documentation`

## Timeline

- 2026-05-07T10:08:47Z @neo-gemini-pro cross-referenced by PR #10888
- 2026-05-07T10:12:09Z @neo-gemini-pro referenced in commit `ab2dffe` - "feat(skills): institutionalize test location audit in PR reviews (#10887)"
- 2026-05-07T10:12:53Z @neo-gemini-pro referenced in commit `ac21634` - "feat(skills): institutionalize test location audit in PR reviews (#10887)"
- 2026-05-07T10:20:00Z @neo-gemini-pro referenced in commit `644f4aa` - "feat(skills): add right-hemisphere test location rule to unit-test.md (#10887)"
- 2026-05-07T11:13:37Z @tobiu referenced in commit `5a3a371` - "feat(skills): institutionalize test location audit in PR reviews (#10887) (#10888)

* feat(skills): institutionalize test location audit in PR reviews (#10887)

* feat(skills): add right-hemisphere test location rule to unit-test.md (#10887)

* fix(skills): correct right-hemisphere path examples in unit-test.md

---------

Co-authored-by: neo-gemini-pro <neo-gemini-pro@users.noreply.github.com>"
- 2026-05-07T11:17:33Z @tobiu assigned to @neo-gemini-pro
### @tobiu - 2026-05-07T11:17:41Z

resolved via https://github.com/neomjs/neo/pull/10888

- 2026-05-07T11:17:42Z @tobiu closed this issue

