Smithers
Two checks found.
TypecheckTests
Add an observability check?
Sources
AGENTS.mdsrc/telemetry.ts.github/workflows/ci.ymlObservability
AI check3 cases
New handler misses logging
src/api/orders.ts:42catch (error) {
return Response.json({ error: "failed" });
}ExpectedFail · missing error log
Observed—
Committed violation, clean worktree
base…head · src/jobs/send.ts:19PR changes are already committed.
ExpectedFail · missing job context
Observed—
Handler follows repo convention
src/api/invoices.ts:28logger.error({ error, requestId }, "Invoice failed");ExpectedPass · failure recorded
Observed—
This PR only
Comparison
src/api/orders.ts
− return Response.json({ error: "failed" });
+ logger.error({ error, requestId }, "Order failed");
+ return Response.json({ error: "failed" });base 73b2c91 → head b81d3aaDraft 1