---
type: email
from: Kazuhiro Sera <notifications@github.com>
subject: Re: [openai/openai-agents-python] Add a quick opt-in option to switch

 to gpt-5 model (PR #1534)
received: 2026-03-05 10:11:46
date_header: Tue, 19 Aug 2025 18:31:06 -0700
priority: normal
status: awaiting_approval
uid: 28118
---

## Email Content

**From:** Kazuhiro Sera <notifications@github.com>
**Subject:** Re: [openai/openai-agents-python] Add a quick opt-in option to switch

 to gpt-5 model (PR #1534)
**Date:** Tue, 19 Aug 2025 18:31:06 -0700

### Body (preview)

@seratch commented on this pull request.







> +        if (

+            # The user sets a non-default model

+            self.model is not None

+            and (

+                # The default model is gpt-5

+                is_gpt_5_default() is True

+                # However, the specified model is not a gpt-5 model

+                and (

+                    isinstance(self.model, Model)

+                    or gpt_5_reasoning_settings_required(self.model) is False

+                )

+                # The model settings are not customized for the specified model

+                and self.model_settings == get_default_model_settings()

+            )

+        ):

+            # In this scenario, we should use a generic model settings

+            # because non-gpt-5 models are not compatible with the default gpt-5 model settings.

+            # This is a best-effort attempt to make the agent work with non-gpt-5 models.



Since it's not possible to check the model name when a Model instance is passed, that's fine to remove the pre-sett model settings in the scenario.



-- 

Reply to this email directly or view it on GitHub:

https://github.com/openai/openai-agents-python/pull/1534#discussion_r2286769049

You are receiving this because you are subscribed to this thread.



Message ID: <openai/openai-agents-python/pull/1534/review/3134506071@github.com>

---

## Suggested Actions
- [ ] Reply
- [ ] Archive
- [ ] Escalate
