---
type: email
from: Rohan Mehta <notifications@github.com>
subject: Re: [openai/openai-agents-python] Add a quick opt-in option to switch

 to gpt-5 model (PR #1534)
received: 2026-03-05 10:14:04
date_header: Thu, 21 Aug 2025 15:22:38 -0700
priority: normal
status: awaiting_approval
uid: 28333
---

## Email Content

**From:** Rohan Mehta <notifications@github.com>
**Subject:** Re: [openai/openai-agents-python] Add a quick opt-in option to switch

 to gpt-5 model (PR #1534)
**Date:** Thu, 21 Aug 2025 15:22:38 -0700

### Body (preview)

@rm-openai commented on this pull request.







> +        if (

+            # The user sets a non-default model

+            self.model is not None

+            and (

+                # The default model is gpt-5

+                is_gpt_5_default() is True

+                # However, the specified model is not a gpt-5 model

+                and (

+                    isinstance(self.model, str) is False

+                    or gpt_5_reasoning_settings_required(self.model) is False  # type: ignore

+                )

+                # The model settings are not customized for the specified model

+                and self.model_settings == get_default_model_settings()

+            )

+        ):

+            # In this scenario, we should use a generic model settings

+            # because non-gpt-5 models are not compatible with the default gpt-5 model settings.

+            # This is a best-effort attempt to make the agent work with non-gpt-5 models.

+            self.model_settings = ModelSettings()

+



this seems complex and fragile. Is there something simpler and less invasive we can do?



> @@ -80,7 +82,7 @@ def _get_client(self) -> AsyncOpenAI:

 

     def get_model(self, model_name: str | None) -> Model:

         if model_name is None:

-            model_name = DEFAULT_MODEL

+            model_name = get_default_model()



can we do only this? feels equally useful



-- 

Reply to this email directly or view it on GitHub:

https://github.com/openai/openai-agents-python/pull/1534#pullrequestreview-3142411378

You are receiving this because you are subscribed to this thread.



Message ID: <openai/openai-agents-python/pull/1534/review/3142411378@github.com>

---

## Suggested Actions
- [ ] Reply
- [ ] Archive
- [ ] Escalate
