---
type: email
from: Sung-jin Brian Hong <notifications@github.com>
subject: Re: [openai/openai-agents-python] fix(chatcmpl): preserve all LiteLLM

 thinking-block signatures in converter (PR #1779)
received: 2026-03-06 07:40:19
date_header: Sun, 21 Sep 2025 22:46:55 -0700
priority: normal
status: awaiting_approval
uid: 30951
---

## Email Content

**From:** Sung-jin Brian Hong <notifications@github.com>
**Subject:** Re: [openai/openai-agents-python] fix(chatcmpl): preserve all LiteLLM

 thinking-block signatures in converter (PR #1779)
**Date:** Sun, 21 Sep 2025 22:46:55 -0700

### Body (preview)

@serialx commented on this pull request.







>                                  "type": "thinking",

                                 "thinking": content_item.get("text", ""),

                             }

-                            # Add signature if available

-                            if signature:

-                                thinking_block["signature"] = signature

+                            # Add signatures if available

+                            if signatures:

+                                thinking_block["signature"] = signatures.pop(0)



All reasoning blocks should always contain signatures, this is basically a N:1 conversion and 1:N back-conversion. So N should always equal. `if signatures` is simply a defensive coding practice.



-- 

Reply to this email directly or view it on GitHub:

https://github.com/openai/openai-agents-python/pull/1779#discussion_r2366782618

You are receiving this because you are subscribed to this thread.



Message ID: <openai/openai-agents-python/pull/1779/review/3250693401@github.com>

---

## Suggested Actions
- [ ] Reply
- [ ] Archive
- [ ] Escalate
