source requirements vs. implementation plan: point-by-point review
| Request | Plan | Status |
|---|---|---|
Scope: product-detail-template only |
Plan limits all changes to the named template. | Match |
| Target delivery window captured in source brief | Plan header repeats the same delivery window. | Match |
| Update notification button label and modal text | Button text + modal description configurable via settings. | Match |
| Use the vendor SDK to trigger notification events | Uses openInlineForm, openModal, removeInlineForm. |
Match |
| Custom button + modal with text settings in buy buttons block | Schema settings in buy_buttons block. |
Match |
| Default values preserve current behavior when empty | Blank settings keep the existing notification behavior. | Match |
| Only display for unavailable variants | DOM-based sold-out detection. | Match |
Exclude products with exclude-notify tag |
Checked in both PDP and PLP Liquid. | Match |
openInlineForm loads the vendor form in the modal |
PDP modal uses openInlineForm. |
Match |
| Updated button label from the source brief | Pre-populated in template JSON. | Match |
| Updated modal copy from the source brief | bis_modal_description setting. |
Match |
| Deployment target named in the source brief | Environment ID is included as a placeholder value. | Match |
| Changes made locally | Local dev + theme push. | Match |
Run vendor:notify-modal:submitted when form is submitted |
Not mentioned in plan.
When using openInlineForm inside a custom modal, unclear if the vendor SDK fires this event automatically or if manual dispatch is needed.
|
Gap |
| 14 items reviewed | 13 match · 1 gap |
vendor:notify-modal:submitted event.
The source brief requires an event on form submission. The plan uses openInlineForm inside a custom modal, but does not address whether the vendor SDK dispatches this event automatically in that context. If analytics or downstream automations listen for it, missing it could silently break the submission pipeline. Recommend adding an explicit dispatchEvent call as a safety net.